Simplyfing `qubit.new` #518

weinbe58 · 2025-09-30T20:07:36Z

Closes #508 however I am not sure where to reexport new since I Can't reexport it into the qubit module. For now I have re-exported it into squin.new.

codecov · 2025-09-30T20:10:55Z

Codecov Report

❌ Patch coverage is 90.69767% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/bloqade/cirq_utils/emit/base.py	88.00%	3 Missing ⚠️
src/bloqade/squin/stdlib/qubit.py	62.50%	3 Missing ⚠️
src/bloqade/squin/qubit.py	93.33%	1 Missing ⚠️
src/bloqade/squin/rewrite/wrap_analysis.py	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

github-actions · 2025-09-30T20:11:06Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
9459	8354	88%	0%	🟢

New Files

File	Coverage	Status
src/bloqade/squin/stdlib/qubit.py	63%	🟢
TOTAL	63%	🟢

Modified Files

File	Coverage	Status
src/bloqade/cirq_utils/emit/base.py	93%	🟢
src/bloqade/cirq_utils/emit/qubit.py	100%	🟢
src/bloqade/cirq_utils/lowering.py	93%	🟢
src/bloqade/pyqrack/squin/qubit.py	96%	🟢
src/bloqade/rewrite/passes/aggressive_unroll.py	100%	🟢
src/bloqade/squin/_init_.py	100%	🟢
src/bloqade/squin/analysis/address_impl.py	100%	🟢
src/bloqade/squin/groups.py	100%	🟢
src/bloqade/squin/qubit.py	98%	🟢
src/bloqade/squin/rewrite/wrap_analysis.py	86%	🟢
src/bloqade/squin/stdlib/broadcast/noise.py	74%	🟢
src/bloqade/stim/passes/flatten.py	100%	🟢
src/bloqade/stim/passes/squin_to_stim.py	100%	🟢
TOTAL	95%	🟢

updated for commit: 15366cb by action🐍

david-pl · 2025-10-01T07:22:11Z

@weinbe58 I thought this was meant to replace the qubit.New statement altogether. If so, then just replace the wrapper by the stdlib function in qubit.new.

weinbe58 · 2025-10-01T15:35:48Z

@weinbe58 I thought this was meant to replace the qubit.New statement altogether. If so, then just replace the wrapper by the stdlib function in qubit.new.

either way I need to put the new stdlib function outside of the qubit.py module because otherwise it will create a circular import

weinbe58 · 2025-10-06T14:08:30Z

TODO:

rename new to qalloc
Remove analysis for ilist.map for now, create another PR later.

src/bloqade/squin/qubit.py

david-pl

Looks good, I just have some minor comments and questions.
FYI, I also checked to make sure that the examples in the documentation still work after this change.

src/bloqade/cirq_utils/emit/base.py

david-pl · 2025-10-17T10:29:18Z

src/bloqade/cirq_utils/emit/base.py

+    new_func = func.Function(
+        sym_name=sym_name, body=callable_region, signature=new_signature
+    )
+    mt_ = ir.Method(None, None, sym_name, [], mt.dialects, new_func)


I admit to being a bit lost here. Why is it necessary to construct a new method like this here? Why is mt_ = mt.similar(mt.dialects) not sufficient?

The signature is different, I removed all the arguments of the function.

src/bloqade/cirq_utils/lowering.py

david-pl · 2025-10-17T10:32:56Z

src/bloqade/squin/qubit.py

 def get_measurement_id(measurement: MeasurementResult) -> int: ...
+
+
+# TODO: investigate why this is needed to get type inference to be correct.


Might be worth considering this as part of #549, since depending on the changes there, MeasureQubit and MeasureQubitList may be consolidated.

cc @johnzl-777

This PR is a bit old now isn't it? I'm all for getting this in first and then I can make the necessary tweaks in a dedicated PR for #549 .

The request for changes might take a bit considering Phillip's in Munich for the Munich Quantum Software Forum

The comment here is more on the Kirin side of things.

In principle the statements typing should just work as it but for some reason it wasn't so I added an explicit type inference method

test/pyqrack/runtime/test_qrack.py

Co-authored-by: David Plankensteiner <[email protected]>

…EraComputing/bloqade-circuit into phil/508-simplifying-qubitnew

src/bloqade/squin/groups.py

weinbe58 · 2025-10-18T08:36:17Z

src/bloqade/squin/qubit.py

 def get_measurement_id(measurement: MeasurementResult) -> int: ...
+
+
+# TODO: investigate why this is needed to get type inference to be correct.


The comment here is more on the Kirin side of things.

In principle the statements typing should just work as it but for some reason it wasn't so I added an explicit type inference method

adding new qubit and stdlib to allocate new qubits

4f4088a

weinbe58 linked an issue Sep 30, 2025 that may be closed by this pull request

simplifying qubit.new #508

Closed

3 tasks

weinbe58 marked this pull request as draft September 30, 2025 20:11

weinbe58 added 2 commits September 30, 2025 16:16

Adding pyqrack interpreter and using that in test

acfa798

Adding test for new stdlib function

fe677ea

weinbe58 added 2 commits October 1, 2025 09:41

marking test as expected to fail

738bfe8

fixing incorrect usage xfail

8396e77

weinbe58 marked this pull request as ready for review October 1, 2025 15:34

Roger-luo reviewed Oct 6, 2025

View reviewed changes

src/bloqade/squin/qubit.py Outdated Show resolved Hide resolved

weinbe58 added the breaking breaking changes or proposed changes that would break existing APIs label Oct 6, 2025

weinbe58 mentioned this pull request Oct 6, 2025

Refactor cirq - squin emit and lowering #520

Merged

weinbe58 added the do not merge do not merge pending on other issues to resolve label Oct 6, 2025

weinbe58 added 4 commits October 6, 2025 15:45

removing print

d9eda24

Merge branch 'main' into phil/508-simplifying-qubitnew

bee7cf6

merging stashed changes

d90907f

WIP fixing tests

9257a32

weinbe58 mentioned this pull request Oct 7, 2025

CirqEmit does not handle allocations inside subroutine. #527

Closed

weinbe58 added 6 commits October 8, 2025 10:06

merging main

9bc330f

Fixing bug in test

a51fc40

fixing some tests

0807726

merging main

a3b7124

merging main

c8ec9a8

Fixing some tests

78e36ed

johnzl-777 mentioned this pull request Oct 16, 2025

RFC: qubit dialect structure conformity with gate/broadcasting #549

Open

removing print

0edcf0f

weinbe58 added 7 commits October 16, 2025 12:48

WIP: trying to fix cirq emit

c28ff2c

fixing test adding fixedpoint to unroll

0944d60

pin lower bound on kirin

ac72611

fixing test

28d1782

fixing tests

a2564d5

fixing potential issue with unroll pass

126b0e5

fixing last test

aa20f7d

weinbe58 requested a review from david-pl October 17, 2025 10:09

david-pl approved these changes Oct 17, 2025

View reviewed changes

weinbe58 and others added 5 commits October 17, 2025 16:16

Update test/pyqrack/runtime/test_qrack.py

0e16e43

Co-authored-by: David Plankensteiner <[email protected]>

Update src/bloqade/cirq_utils/emit/base.py

6829892

Co-authored-by: David Plankensteiner <[email protected]>

removing print

a716da4

Merge branch 'phil/508-simplifying-qubitnew' of https://github.com/Qu…

ba8acdc

…EraComputing/bloqade-circuit into phil/508-simplifying-qubitnew

removing print

7c53555

weinbe58 commented Oct 18, 2025

View reviewed changes

Update groups.py

15366cb

weinbe58 merged commit 19dd7b3 into main Oct 18, 2025
11 checks passed

weinbe58 deleted the phil/508-simplifying-qubitnew branch October 18, 2025 08:48

		def get_measurement_id(measurement: MeasurementResult) -> int: ...


		# TODO: investigate why this is needed to get type inference to be correct.

Simplyfing qubit.new #518

Simplyfing qubit.new #518

Uh oh!

Conversation

weinbe58 commented Sep 30, 2025

Uh oh!

codecov bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

Uh oh!

david-pl commented Oct 1, 2025

Uh oh!

weinbe58 commented Oct 1, 2025

Uh oh!

weinbe58 commented Oct 6, 2025

Uh oh!

Uh oh!

david-pl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

david-pl Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

weinbe58 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

david-pl Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

johnzl-777 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

weinbe58 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

weinbe58 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Simplyfing `qubit.new` #518

Simplyfing `qubit.new` #518

codecov bot commented Sep 30, 2025 •

edited

Loading

github-actions bot commented Sep 30, 2025 •

edited

Loading